Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change license to BSD-2-Clause #121

Merged
merged 12 commits into from
Nov 12, 2024
Merged

Change license to BSD-2-Clause #121

merged 12 commits into from
Nov 12, 2024
+338 −408

Conversation

dehanj
Copy link
Member

@dehanj dehanj commented Oct 23, 2024 •
edited
Loading

Description

  • License update to BSD-2-Clause
  • Follow reuse spec
  • Bump dependencies, especially tkey-device-signer, tkeyutil and tkeyclient that are changed from GPLv2 only to BSD-2-Clause.
  • Update golanglint-ci
  • Fix issues newer golanglint-ci warns about
  • Remove dco

Type of change

Please tick any that are relevant to this PR and remove any that aren't.

  • Feature (non breaking change which adds functionality)
  • Documentation (a change to documentation)

Submission checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my changes
  • I have tested and verified my changes on target
  • My changes are well written and CI is passing
  • I have squashed my work to relevant commits and rebased on main for linear history
  • I have added a "Co-authored-by: x" if several people contributed, either pair programming or by squashing commits from different authors.
  • I have updated the documentation where relevant (readme, dev.tillitis.se etc.)

@dehanj dehanj requested a review from mchack-work October 23, 2024 07:59
@dehanj dehanj marked this pull request as ready for review October 23, 2024 08:00
@dehanj dehanj marked this pull request as draft October 23, 2024 08:01
@dehanj dehanj force-pushed the change-license branch 4 times, most recently from dfcdd86 to b6af9ba Compare October 23, 2024 09:32
@dehanj dehanj changed the title Change license Change license to BSD-2-Clause Oct 23, 2024
@mchack-work
Copy link
Member

Removed some build artefacts from the REUSE spec, changed missing license expression in Debian control file and goreleaser. Goreleaser builds packages fine.

Want to see if dpkg complains when installing package on Debian before approving.

@dehanj
Copy link
Member Author

dehanj commented Nov 12, 2024 •
edited
Loading

tkeyclient bump commit disappeared, so added it back and also bumped tkeysign.
Now there should not be any GPL dependencies left.

@dehanj dehanj marked this pull request as ready for review November 12, 2024 08:54
@mchack-work mchack-work mentioned this pull request Nov 12, 2024
Closed
mchack-work
mchack-work approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@mchack-work mchack-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changed typos in tkeysign bump.
  • Tested to install the .deb from goreleaser
  • Remove toolchain from go.mod

Merging.

dehanj and others added 12 commits November 12, 2024 17:05
@dehanj @mchack-work
Bump Go dependencies for tkey-ssh-agent
b6ccb80 
- tkeyutil is now released under BSD-2-Clause
@dehanj @mchack-work
Bump Go dependencies for go-winres
45065b6
@dehanj @mchack-work
Bump dependency tkeyclient to v1.1.0
4026869 
- tkeyclient is now released under BSD-2-Clause
@dehanj @mchack-work
Bump dependency tkeysign to v1.0.1
44bb250 
- tkeysign is now released under BSD-2-Clause
@dehanj @mchack-work
Update embedded signer to v1.0.2. Does not change CDI.
4592e59 
v1.0.2 of the signer is licensed under BSD-2-Clause
@dehanj @mchack-work
Remove dco.md
1705fc6 
The DCO is deemd unnecessary since GitHub's Terms of Service covers the
same topics. See GitHub's Terms of Service D3 and D6.
@dehanj @mchack-work
Change license to BSD-2-Clause
79f9cf9 
This was announced on the Tillitis Blog the 2nd of October 2024, for
more info visit https://tillitis.se

Co-authored-by: Michael Cardell Widerkrantz <mc@tillitis.se>
@dehanj @mchack-work
Follow REUSE specification
613cf0b 
- Add REUSE configuration
- Add compliant license in LICENSES/
- Add copyright SPDX tags
- Run REUSE Compliance check in CI
@dehanj @mchack-work
Fix typo in man page
7dffc8e
@dehanj @mchack-work
Update golanglint-ci
76eb685
@dehanj @mchack-work
Fix wrong order of arguments for errors.Is
10276e0
@mchack-work
Remove Go toolchain from go.mod
14bd4b7 
In CI we like to control what exact version of the Go compiler is used
in our own OCI image.
@mchack-work mchack-work merged commit 14bd4b7 into main Nov 12, 2024
6 checks passed
@mchack-work mchack-work deleted the change-license branch November 12, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchack-work mchack-work mchack-work approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dehanj @mchack-work